Skip to content

Wireless Design Bug Fix#41

Merged
madhansansel merged 1 commit into
mainfrom
wireeless_design_bug_fix
Jul 3, 2026
Merged

Wireless Design Bug Fix#41
madhansansel merged 1 commit into
mainfrom
wireeless_design_bug_fix

Conversation

@shatagopasunil

Copy link
Copy Markdown

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

PR Description

Issue:
Creating an aaa_radius_attribute template fails if called_station_id is not provided in the playbook, even though the Catalyst Center API treats it as an optional field.

RCA:
The called_station_id field was marked as required: true in the module documentation, and the validation logic unconditionally checked its value against the allowed list — causing a failure when the value was None. Additionally, update and create payloads always included calledStationId regardless of whether it was provided, sending None to the API.

Fix:

  • Changed called_station_id from required: true to required: false in the module documentation.
  • Made the allowed-values validation conditional — only runs when called_station_id is explicitly provided.
  • Payloads now preserve the existing calledStationId from Catalyst Center when no new value is provided.

Testing Done:

  • Manual testing
  • Unit tests
  • [] Integration tests

Test cases covered: [Mention test case IDs or brief points]

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • All the sanity checks have been completed and the sanity test cases have been executed

Ansible Best Practices

  • Tasks are idempotent (can be run multiple times without changing state)
  • Variables and secrets are handled securely (e.g., using ansible-vault or environment variables)
  • Playbooks are modular and reusable
  • Handlers are used for actions that need to run on change

Documentation

  • All options and parameters are documented clearly.
  • Examples are provided and tested.
  • Notes and limitations are clearly stated.

Screenshots (if applicable)

Notes to Reviewers

@shatagopasunil shatagopasunil changed the title WWireless Design Bug Fix Wireless Design Bug Fix Jun 29, 2026
@madhansansel madhansansel merged commit fab5474 into main Jul 3, 2026
24 checks passed
@shatagopasunil shatagopasunil deleted the wireeless_design_bug_fix branch July 6, 2026 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants